Skip to content

Fix Task.WhenEach not polyfilled on .NET Standard 2.0 when Microsoft.Bcl.AsyncInterfaces is present or .NET Standard 2.1 #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 5 commits into from
Feb 26, 2026
Merged

Fix Task.WhenEach not polyfilled on .NET Standard 2.0 when Microsoft.Bcl.AsyncInterfaces is present or .NET Standard 2.1 #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9cedfb
allow FeatureAsyncInterfaces to work where supported
alastairlundy Feb 24, 2026
5a4350c
enable testing Task.WhenEach polyfill with FeatureAsyncInterface
alastairlundy Feb 25, 2026
f84f476
Update PolyfillTests_Task.cs
alastairlundy Feb 25, 2026
e72a3c5
Update PolyfillTests_Task.cs
alastairlundy Feb 25, 2026
95e2073
Remove NET9_0_OR_GREATER check for async features
SimonCropp Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Polyfill/TaskWhenEachPolyfill.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if !NET9_0_OR_GREATER && (NET5_0_OR_GREATER || NETCOREAPP3_0_OR_GREATER) && FeatureAsyncInterfaces

#if !NET9_0_OR_GREATER && FeatureAsyncInterfaces
namespace Polyfills;

using System;
Expand Down
5 changes: 2 additions & 3 deletions src/Tests/PolyfillTests_Task.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,8 +609,7 @@ public async Task WaitAsync_InfiniteTimeoutAndNoCancellation_ReturnsOriginalTask

#endregion

#if NET5_0_OR_GREATER || NETCOREAPP3_0_OR_GREATER

#if FeatureAsyncInterfaces
#region WhenEach Tests

[Test]
Expand Down Expand Up @@ -881,4 +880,4 @@ async Task<T> ThrowExceptionAsync<T>()

#endregion
}
#endif
#endif
1 change: 1 addition & 0 deletions src/Tests/Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<PackageReference Include="ProjectDefaults" PrivateAssets="all" />
<PackageReference Include="ProjectFiles" />
<PackageReference Include="System.Memory" Condition="$(TargetFrameworkIdentifier) == '.NETStandard' or $(TargetFrameworkIdentifier) == '.NETFramework' or $(TargetFramework.StartsWith('netcoreapp'))" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="$(TargetFramework.StartsWith('net4')) OR $(TargetFramework) == 'netstandard2.0'"/>
<PackageReference Include="System.ValueTuple" Condition="$(TargetFramework.StartsWith('net46'))" />
<PackageReference Include="System.Net.Http" Condition="$(TargetFramework.StartsWith('net4'))" />
<PackageReference Include="System.Threading.Tasks.Extensions" Condition="$(TargetFramework) == 'netstandard2.0' or $(TargetFramework) == 'netcoreapp2.0' or $(TargetFrameworkIdentifier) == '.NETFramework'" />
Expand Down
Loading