Add Abgr32 pixel type, extend IPixel<T>#1886
Merged
JimBobSquarePants merged 12 commits intoSixLabors:masterfrom Dec 18, 2021
Merged
Add Abgr32 pixel type, extend IPixel<T>#1886JimBobSquarePants merged 12 commits intoSixLabors:masterfrom
JimBobSquarePants merged 12 commits intoSixLabors:masterfrom
Conversation
Collaborator
|
@antonfirsov there seem to be failing tests on macos, which may be related to #1730, could you take a look at this: Failing Tests |
4 tasks
gfoidl
reviewed
Dec 11, 2021
| /// <summary> | ||
| /// Provides optimized overrides for bulk operations. | ||
| /// </summary> | ||
| internal partial class PixelOperations : PixelOperations<Abgr32> |
Contributor
There was a problem hiding this comment.
Can this be sealed?
Sealing would open the door in the JIT to allow de-virtualization, especially with dynamic profile guided optimizaiton (D-PGO).
...elFormats/PixelImplementations/PixelOperations/Generated/Abgr32.PixelOperations.Generated.cs
Outdated
Show resolved
Hide resolved
gfoidl
reviewed
Dec 11, 2021
src/ImageSharp/PixelFormats/PixelImplementations/PixelOperations/Generated/_Common.ttinclude
Outdated
Show resolved
Hide resolved
gfoidl
reviewed
Dec 11, 2021
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 957 960 +3
Lines 50474 50972 +498
Branches 6291 6310 +19
=======================================
+ Hits 44252 44731 +479
- Misses 5185 5202 +17
- Partials 1037 1039 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
antonfirsov
previously approved these changes
Dec 17, 2021
Member
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
LGTM, thanks!
This is a breaking change due to IPixel<T> interface extension.
Closed
antonfirsov
changed the title
This was referenced Jul 30, 2025
This was referenced Sep 23, 2025
This was referenced Oct 3, 2025
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This adds the Abgr32 Pixel Format, as described in issue #1345.
For most of its implementation, I took inspiration from the Bgra32 pixel format code. It includes the SIMD conversions to other RGB based formats, so conversion performance should be pretty good.
I also fixed, what I think is a bug, in IComponentShuffle. Please check if my understanding of byte shuffling is correct.
I've not added Benchmarks, as there weren't any for Bgra32 also. I expect the performance will be similar to the other RGBA Pixel Formats. Let me know if you want me to add benchmarks.