Backport 2759 to 2.1.x#2770
Merged
JimBobSquarePants merged 7 commits intorelease/2.1.xfrom Jul 15, 2024
Merged
Conversation
Signed-off-by: antonfirsov <antonfir@gmail.com>
Signed-off-by: antonfirsov <antonfir@gmail.com>
JimBobSquarePants
approved these changes
Jul 15, 2024
Member
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Thanks for doing this!
I think incorporating the full decoder was probably wise here. There were likely other critical issues missed over time that should be included.
The jpeg issue in v3.1.x was that the chrominance quality was being determined as zero. This led to the encoder trying to divide by that value. I'm fine with decoder throwing an exception here.
This was referenced Jul 23, 2025
This was referenced Jul 30, 2025
This was referenced Sep 23, 2025
This was referenced Oct 3, 2025
This was referenced Oct 17, 2025
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Implemented it by a full port of 3.1.x Gif Decoder, so it contains improvements and behavioral changes made since then. It also decodes some stuff 2.1 API doesn't expose.
I didn't fully understand what was the JPEG change about, but the 2.1 decoder detects it as an invalid image. Added the test as a skipped test.