Add Fees#1764
Open
alistair-singh wants to merge 3 commits intomainfrom
Open
Conversation
yrong
reviewed
Apr 16, 2026
| txValueUsd: bigint // USD value of the transaction (whole USD, bigint) | ||
| ethToUsdNumerator: bigint // e.g. 2500n if 1 ETH = $2500 | ||
| ethToUsdDenominator: bigint // e.g. 1n (simple ratio). Use denominator > 1 for fractional prices. | ||
| } |
Contributor
There was a problem hiding this comment.
Are we planning to leave this to the UI to provide it, or should it be calculated internally in the SDK, using a price oracle?
Contributor
Author
There was a problem hiding this comment.
Planing to leave this to the UI to do. Because I dont want to rely on apis/keys here.
alistair-singh
force-pushed
the
alistair/fee-update
branch
from
5062ee5 to
fb4e21a
Compare
alistair-singh
force-pushed
the
alistair/fee-update
branch
from
fb4e21a to
fe3f55a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.