Only add implementation for Arc if the target supports it#70
Merged
finnbear merged 4 commits intoSoftbearStudios:mainfrom Mar 25, 2025
Merged
Only add implementation for Arc if the target supports it#70finnbear merged 4 commits intoSoftbearStudios:mainfrom
Arc if the target supports it#70finnbear merged 4 commits intoSoftbearStudios:mainfrom
Conversation
Member
|
Thanks very much! Is it possible to add a CI step that checks compilation on that target? I'd like to avoid breaking this in the future. |
Contributor
Author
|
I tried to add it but it seems like zstd doesn't work on that target. Should I handle this specific target similiar to miri and add it to the Lines 35 to 37 in 1604d52 Or what do you think is the best solution? |
Contributor
Author
|
I had a better idea now: Just run |
finnbear
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
EncodeandDecodetraits are always implemented foralloc::sync::Arcregardless of whether theArctype is actually available. When compiling to a target that does not have atomic pointers (e.g. thumbv6m-none-eabi) the compiler emits the following error message:With this change the traits are only implemented if the
Arctype exists.