Skip to content

feat: extend department codes lengths in database schema #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mini-bomba merged 2 commits into from
Mar 20, 2026
Merged

feat: extend department codes lengths in database schema #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf7ddc
feat: extend department codes lengths in database schema
czaja307 Mar 20, 2026
faa6d5a
feat(models): add code length validators
mini-bomba Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/models/department.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import vine from "@vinejs/vine";
import { DateTime } from "luxon";

import { BaseModel, belongsTo, hasMany } from "@adonisjs/lucid/orm";
Expand Down Expand Up @@ -30,10 +31,16 @@ export default class Department extends BaseModel {
@typedColumn({ type: Branch })
declare branch: Branch;

@typedColumn({ type: "string" })
@typedColumn({
type: "string",
validator: vine.string().trim().minLength(1).maxLength(30),
})
declare code: string;

@typedColumn({ type: "string" })
@typedColumn({
type: "string",
validator: vine.string().trim().minLength(1).maxLength(30),
})
declare betterCode: string;

@typedColumn({ foreignKeyOf: () => FileEntry, optional: true })
Expand Down
19 changes: 19 additions & 0 deletions database/migrations/1774003334447_create_extend_department_codes_lengths_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { BaseSchema } from "@adonisjs/lucid/schema";

export default class extends BaseSchema {
protected tableName = "departments";

async up() {
this.schema.alterTable(this.tableName, (table) => {
table.string("code", 30).notNullable().alter();
table.string("better_code", 30).notNullable().alter();
});
}

async down() {
this.schema.alterTable(this.tableName, (table) => {
table.string("code", 3).notNullable().alter();
table.string("better_code", 5).notNullable().alter();
});
}
}
Loading