First commit with eda for parking and sks data#2
Open
DamianRyczko wants to merge 1 commit intomainfrom
Open
Conversation
Member
DominikaStefaniak
left a comment
There was a problem hiding this comment.
The EDA looks great, it's very extensive which provides nice insights into the datasets. I only have a few suggestions on how you could improve it:
- avoid large outputs like head(100) or head(288) in order to keep the file size manageable and avoid issues when pushing to GitHub. It is better to use smaller samples or visualize the data through plots,
- remember about the commit naming convention described in the Solvro docs,
- great that you consistently used English, there was just one exception in the folder path "Dane", it is better to rename it to "data" to maintain consistency (I will add it to readme, sorry for that),
- I think it would be better to use groupby on a single DataFrame rather than splitting the parking availability into five separate ones to avoid duplicating code for every parking lot,
- you've had great conclusions, to make the EDA more complete you could add Markdown descriptions for the less obvious fragments to explain the purpose behind operations.
These are just small fixes, as the overall EDA is very well-conducted and gives a solid foundation for the next steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.