Skip to content

First commit with eda for parking and sks data#2

Open
DamianRyczko wants to merge 1 commit intomainfrom
experiment/damian-eda
Open

First commit with eda for parking and sks data#2
DamianRyczko wants to merge 1 commit intomainfrom
experiment/damian-eda

Conversation

@DamianRyczko
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@DominikaStefaniak DominikaStefaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EDA looks great, it's very extensive which provides nice insights into the datasets. I only have a few suggestions on how you could improve it:

  • avoid large outputs like head(100) or head(288) in order to keep the file size manageable and avoid issues when pushing to GitHub. It is better to use smaller samples or visualize the data through plots,
  • remember about the commit naming convention described in the Solvro docs,
  • great that you consistently used English, there was just one exception in the folder path "Dane", it is better to rename it to "data" to maintain consistency (I will add it to readme, sorry for that),
  • I think it would be better to use groupby on a single DataFrame rather than splitting the parking availability into five separate ones to avoid duplicating code for every parking lot,
  • you've had great conclusions, to make the EDA more complete you could add Markdown descriptions for the less obvious fragments to explain the purpose behind operations.

These are just small fixes, as the overall EDA is very well-conducted and gives a solid foundation for the next steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants