Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new user setting to cap how many times a question may reoccur in a quiz session, wiring it into session progress calculations and exposing it in the profile settings UI.
Changes:
- Extend
UserSettingswithmax_question_reoccurrencesand provide a default value. - Enforce the cap in
getRemainingAttempts()and factor out a shared question “count” helper. - Add UI controls (input + slider) for the new setting in the profile settings form.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/types/user.ts |
Adds max_question_reoccurrences to the settings type and defaults. |
src/lib/session-utils.ts |
Applies the max-reoccurrence cap in remaining-attempts logic and introduces getQuestionAnsweredCount(). |
src/components/quiz/question-card.tsx |
Reuses the shared count helper for the “times shown” badge. |
src/components/profile/settings-form.tsx |
Adds input/slider controls to edit max_question_reoccurrences. |
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Adds a new user setting to cap how many times a question can reappear in a single quiz session, wiring it through quiz session logic and the profile settings UI.
Changes:
- Extend
UserSettingswithmax_question_reoccurrencesand a default value. - Enforce the max reoccurrence cap in
getRemainingAttempts()and refactor “times shown” counting into a shared helper. - Add a new “Maksymalna liczba powtórzeń pytania” control (input + slider) in the profile settings form.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/types/user.ts |
Adds max_question_reoccurrences to settings type + default. |
src/lib/session-utils.ts |
Applies max-cap in remaining-attempts computation; introduces shared count helper. |
src/components/quiz/question-card.tsx |
Uses shared helper to display “times shown” badge. |
src/components/profile/settings-form.tsx |
Adds UI controls to edit the new setting. |
You can also share your feedback on Copilot code review. Take the survey.
…ces' into feat/134-max-question-reoccurrences
There was a problem hiding this comment.
Pull request overview
Adds a new user setting to cap how many times a single question can reappear during a quiz session, and reuses a shared helper to display/compute per-question attempt counts.
Changes:
- Extend
UserSettingswithmax_question_reoccurrences(nullable) and add a default value. - Enforce the max reoccurrence limit in quiz session computations (
getRemainingAttempts). - Reuse a shared helper for “times shown/answered” counting in
QuestionCardand introduce UI controls for the new setting in the profile settings form.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/types/user.ts | Adds max_question_reoccurrences to user settings and provides a default. |
| src/lib/session-utils.ts | Enforces a per-question max appearance/answer limit and introduces a shared counting helper. |
| src/components/quiz/question-card.tsx | Switches to the shared counting helper for the “times shown” badge. |
| src/components/profile/settings-form.tsx | Adds input+slider controls for configuring max_question_reoccurrences and updates existing slider commit behavior. |
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
This PR introduces a new user setting to cap how many times a question can reoccur during a quiz session, and updates both the quiz logic and profile settings UI to support it.
Changes:
- Add
max_question_reoccurrencestoUserSettingswith a default value. - Enforce the max reoccurrence limit in quiz session progress calculations.
- Refactor question “times shown” counting into a shared helper and update the profile settings UI to edit the new value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/types/user.ts | Extends UserSettings with max_question_reoccurrences and adds a default value. |
| src/lib/session-utils.ts | Applies the max reoccurrence cap when computing remaining attempts; adds getQuestionAnsweredCount. |
| src/components/quiz/question-card.tsx | Reuses getQuestionAnsweredCount instead of duplicating the counting logic. |
| src/components/profile/settings-form.tsx | Adds UI control for max reoccurrences and replaces sliders with +/- + numeric inputs. |
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Adds a new user setting to cap how many times a question can reappear during a quiz session, and updates quiz/session utilities + UI to respect and display appearance counts.
Changes:
- Extend
UserSettingswithmax_question_reoccurrencesand add a default value. - Enforce the max reoccurrence limit in
getRemainingAttempts()and extract shared counting logic intogetQuestionAnsweredCount(). - Update quiz question UI to use the shared count helper, and revamp profile settings UI to allow editing the new value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| src/types/user.ts | Adds max_question_reoccurrences, adjusts settings change typing, updates defaults. |
| src/lib/session-utils.ts | Enforces max reoccurrences in remaining-attempt logic; introduces getQuestionAnsweredCount(). |
| src/components/quiz/question-card.tsx | Reuses getQuestionAnsweredCount() instead of duplicating reduce logic. |
| src/components/profile/settings-form.tsx | Replaces sliders with +/- controls and adds UI for max reoccurrences. |
You can also share your feedback on Copilot code review. Take the survey.
|
@MarvinRucinski zobacz sobie czy wszystko pasi, poklikaj sobie w guziczki :) |
|
Moje ulubione zadanie - klikanie guziczków |
|
Będę dawał ci więcej takich zadanek :> |
* feat: add max question reoccurrences slider * feat: add max question reoccurrences slider * feat: max question reoccurrences logic * refactor: use utils function * refactor: slider change * feat: add slider descriptions * refactor: edit session answers count logic * refactor: upgrade save slider values * refactor: upgrade settings logic * refactor: upgrade settings slider logic * refactor: change default settings * feat: new settings form * refactor: responsive * fix: bug fixes * refactor: settings change * refactor: buttons change
* feat: add max question reoccurrences slider * feat: add max question reoccurrences slider * feat: max question reoccurrences logic * refactor: use utils function * refactor: slider change * feat: add slider descriptions * refactor: edit session answers count logic * refactor: upgrade save slider values * refactor: upgrade settings logic * refactor: upgrade settings slider logic * refactor: change default settings * feat: new settings form * refactor: responsive * fix: bug fixes * refactor: settings change * refactor: buttons change
No description provided.