Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a dead link in the hero section by refactoring navigation functionality and redirecting from a broken /about route to a fragment on the current page.
- Extracted duplicate scroll navigation logic into a reusable helper function
- Updated hero section button to navigate to an about fragment instead of a broken
/aboutpage - Applied the new helper function to existing navbar link functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/helpers.ts | New helper function for smooth scrolling to page elements with URL updates |
| src/components/navigation/navbar-link.tsx | Refactored to use the new helper function instead of duplicate code |
| src/app/page.tsx | Updated hero button to use fragment navigation instead of broken /about link |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
13d5273 to
0669255
Compare
6a445b9 to
b1b4463
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #19
resolves #37