Skip to content

Fix StackOverflow in CfgAllPathValidator.AreAllSuccessorsValid #8984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavel-mikula-sonarsource merged 23 commits into from
Mar 28, 2024
Merged

Fix StackOverflow in CfgAllPathValidator.AreAllSuccessorsValid #8984

pavel-mikula-sonarsource merged 23 commits into from
Mar 28, 2024

Conversation

@martin-strecker-sonarsource
Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource commented Mar 26, 2024 •
edited
Loading

Fixes #8977

@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request Mar 26, 2024
Closed
@martin-strecker-sonarsource martin-strecker-sonarsource marked this pull request as ready for review March 27, 2024 11:36
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The visited logic seems to have a gap in the deduplication

@martin-strecker-sonarsource martin-strecker-sonarsource changed the title Reproducer for StackOverflow in CfgAllPathValidator.AreAllSuccessorsValid Fix StackOverflow in CfgAllPathValidator.AreAllSuccessorsValid Mar 27, 2024
@martin-strecker-sonarsource
Copy link
Contributor Author

martin-strecker-sonarsource commented Mar 27, 2024

/azp run

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource enabled auto-merge (squash) March 28, 2024 16:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 3b39e73 into master Mar 28, 2024
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Martin/Repro_8977 branch March 28, 2024 16:12
@martin-strecker-sonarsource
Copy link
Contributor Author

martin-strecker-sonarsource commented Apr 2, 2024

Peach validation

  • S2190: No changes -> as expected
  • S3604: No changes -> as expected

@mary-georgiou-sonarsource mary-georgiou-sonarsource modified the milestones: 9.23.1, 9.24 Apr 2, 2024
@dependabot dependabot bot mentioned this pull request Sep 15, 2025
Open
@dependabot dependabot bot mentioned this pull request Nov 16, 2025
Closed
@dependabot dependabot bot mentioned this pull request Dec 22, 2025
Closed
This was referenced Dec 29, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Jan 8, 2026
Closed
This was referenced Jan 19, 2026
Closed
Closed
This was referenced Jan 30, 2026
Open
Closed
@dependabot dependabot bot mentioned this pull request Feb 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels

None yet

Projects

None yet

Milestone

9.23.1

Development

Successfully merging this pull request may close these issues.

CfgAllPathValidator AreAllSuccessorsValid Stack Overflow on Windows and error MSB6006 in Linux Codespaces

3 participants

@martin-strecker-sonarsource @pavel-mikula-sonarsource @mary-georgiou-sonarsource