SONARJAVA-5754 : Increment and decrement operators (++/--) should not be used with floating point variables

[rombirli]

Waiting on this PR to add asciidoc and metadata

[hashicorp-vault-sonar-prod]

SONARJAVA-5754

[tomasz-tylenda-sonarsource]

Conditions that are always be true have an annoying habit of triggering low code coverage ;) Let me know if this happens and I'll show you the workaround.

[rombirli]

Yes it seems it has an impact on branch coverage, I'm interested in knowing more about this workaround

[tomasz-tylenda-sonarsource]

You wrap tree in an optional and convert if-then into fuctional programming. It looks weird and is unreadable, but the coverage does not look inside :)

    Optional.of(tree)
      .filter(UnaryExpressionTree.class::isInstance)
      .map(UnaryExpressionTree.class::cast)
      .map(UnaryExpressionTree::expression)
      .filter(IdentifierTree.class::isInstance)
      .map(IdentifierTree.class::cast)
      .filter(identifier -> isFloatingPoint(identifier.symbolType()))
      .ifPresent(identifier -> reportIssue(...));

[tomasz-tylenda-sonarsource]

I'll take another look when the rspec is merged.

[tomasz-tylenda-sonarsource]

You wrap tree in an optional and convert if-then into fuctional programming. It looks weird and is unreadable, but the coverage does not look inside :)

    Optional.of(tree)
      .filter(UnaryExpressionTree.class::isInstance)
      .map(UnaryExpressionTree.class::cast)
      .map(UnaryExpressionTree::expression)
      .filter(IdentifierTree.class::isInstance)
      .map(IdentifierTree.class::cast)
      .filter(identifier -> isFloatingPoint(identifier.symbolType()))
      .ifPresent(identifier -> reportIssue(...));

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
96.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube