Move to edit mode of a menu item

[garudaonekh]

Hi,
I am trying to implement a step by step setting. i.e after user set Hour, show Minute spinner. and so on. I based on your todo list example.

Current status: I can show Minute spinner and move focus to it after user set Hour.

But I can't figure out how to go to edit mode of Minute. I try to use menu.registerKeyPress(KEY_OK) to mimick user click but it crash.

[Spirik]

Hi! Can your provide snippet of your code?

Are you adding minutes spinner dynamically via addMenuItem() or just show item that was previously hidden (via show())? Dynamic memory management can be tricky (and not all that recommended on Arduino boards and MCUs in general), so it is better to avoid it whenever possible.

How are you moving focus to Minute spinner (there is one small example in wiki which can be found here, but I wonder, whether you are using another solution, e.g. calling registerKeyPress() to navigate to it)?

[garudaonekh]

When Hour menu item is set, Minute menu item is shown and move focus to it. But I can't find a way to go to its edit mode directly unless user click on OK.

GEMItem menuItemProgramHour("em:agebIk",pHour, spinnerHour, pHourCallback, GEM_VAL_BYTE);


void pHourCallback(GEMCallbackData callbackData){
  menuItemProgramMinute.hide(false);
  ((GEMPageProxy*)menu.getCurrentMenuPage())->setCurrentItemNum(2);
  menu.drawMenu();
}

I try to call menu.registerKeyPress(KEY_OK) after menu.drawMenu() in the callback. but this crash.

[Spirik]

I was able to reproduce an issue and will prepare fix. Thank you for bringing this to my attention!

The issue itself lies in order at which user-defined callback is called and inner mechanics of exiting an edit mode. callbackAction firing before inner method exitEditValue() may lead to not-intuitive results, e.g. when author of the sketch tries to call registerKeyPress(), menu state at that point will operate with assumption that is is still in edit mode (_editValueMode == true). So callback fires when associated with menu item variable is saved but before exit from edit mode.

[garudaonekh]

I was able to reproduce an issue and will prepare fix. Thank you for bringing this to my attention!

The issue itself lies in order at which user-defined callback is called and inner mechanics of exiting an edit mode. callbackAction firing before inner method exitEditValue() may lead to not-intuitive results, e.g. when author of the sketch tries to call registerKeyPress(), menu state at that point will operate with assumption that is is still in edit mode (_editValueMode == true). So callback fires when associated with menu item variable is saved but before exit from edit mode.

Rather than sending GEM_KEY_OK, i call menuItemSelect() directly by moving it to public function also doesn't work(nothing happen). Somehow, if I call menuItemSelect() later, it works.

It's more natural to call menuItemSelect() rather than simulate GEM_OK

[Spirik]

Solution with registerKeyPress() should work fine after the fix is implemented. I also intend to make setCurrentItemNum() method public, so you won't have to override GEMPage class in order to access it.

However, there may be slight difference in callback code between U8g2 and Adafruit GFX versions of GEM (due to inner workings). Which version of GEM do you use?

[garudaonekh]

I use TFT_espi. I change your adafruit_GFX tft to TFT_espi instead.

[Spirik]

Does your display have buffer (e.g. SH110X series), so you have to call display.display() after each drawMenu() call explicitly in order to send updates to the screen and force actual redraw? Such as the case with Todo list example. Or additional call is not needed (e.g. ST7735 based displays), as in the case with other examples?

[garudaonekh]

Does your display have buffer (e.g. SH110X series), so you have to call display.display() after each drawMenu() call explicitly in order to send updates to the screen and force actual redraw? Such as the case with Todo list example. Or additional call is not needed (e.g. ST7735 based displays), as in the case with other examples?

Migrating from adafruitGFX ST7735 to TFT_espi is very smooth. both library use virtually all the same method name. The only difference is TFT_espi use tft.begin() while adafruit_gfx use tft.initR(INITR_BLACKTAB)

The reason I switch to tft_espi is font rendering issue.

[garudaonekh]

The work around for menuItemSelect() to work is to set the flag and call it from loop function() rather than calling it immediately after menu.drawMenu()

[Spirik]

The flag workaround will probably work for registerKeyPress() version as well (set flag in your callback then call registerKeyPress() from within loop()).

[garudaonekh]

The flag workaround will probably work for registerKeyPress() version as well (set flag in your callback then call registerKeyPress() from within loop()).

yes, because registerKeyPress(GEM_KEY_OK) will call menuItemSelect().