Add EventManager#registerListeners with lookup parameter #2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zml2008
approved these changes
Oct 16, 2022
zml2008
added
system: event
status: accepted
type: enhancement
api: 9 (u)
A248
added a commit
to A248/LibertyBans
that referenced
this pull request
Aug 17, 2023
Leverage SpongePowered/SpongeAPI#2441 if available. Otherwise fallback to method scanning and warn user.
A248
added a commit
to A248/LibertyBans
that referenced
this pull request
Aug 17, 2023
Leverage SpongePowered/SpongeAPI#2441 if available. Otherwise fallback to method scanning and warn user.
A248
added a commit
to A248/LibertyBans
that referenced
this pull request
Aug 17, 2023
* Use Sponge register listener with lookup API if possible. Leverage SpongePowered/SpongeAPI#2441 if available. Otherwise fallback to method scanning and warn user. * Implement AlwaysAvailableMuteCache#clearCachedMuteIf for faster unmute resolution * Add fast-path for user lookups when running on Folia
A248
added a commit
to A248/LibertyBans
that referenced
this pull request
Aug 17, 2023
* Use Sponge register listener with lookup API if possible. Leverage SpongePowered/SpongeAPI#2441 if available. Otherwise fallback to method scanning and warn user. * Implement AlwaysAvailableMuteCache#clearCachedMuteIf for faster unmute resolution * Add fast-path for user lookups when running on Folia
A248
added a commit
to A248/LibertyBans
that referenced
this pull request
Aug 17, 2023
* Use Sponge register listener with lookup API if possible. Leverage SpongePowered/SpongeAPI#2441 if available. Otherwise fallback to method scanning and warn user. * Implement AlwaysAvailableMuteCache#clearCachedMuteIf for faster unmute resolution * Add fast-path for user lookups when running on Folia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per SpongePowered/Sponge#3747, the provided lookup allows the EventManager implementation to have privileged access to the listener class. This is particularly useful where the listener class is created outside the normal plugin classloader.
SpongeAPI | Sponge