Expose minecraft:blocks_attacks and minecraft:weapon #2604
Merged
+307
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaruus1
changed the title
aromaa
reviewed
Sep 27, 2025
Member
aromaa
left a comment
aromaa
left a comment
There was a problem hiding this comment.
The keys are also inconsistent with being prefixed with shield or blocking, it should be consistent across the keys.
Also please sort them.
src/main/java/org/spongepowered/api/data/type/ShieldDamageReduction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/api/data/type/ShieldItemDamageFunction.java
Outdated
Show resolved
Hide resolved
avaruus1
force-pushed
the
keys-weapon-shield
branch
from
407f69b to
8b31074
Compare
Co-authored-by: Joni Aromaa <[email protected]>
aromaa
approved these changes
Sep 28, 2025
Member
aromaa
left a comment
aromaa
left a comment
There was a problem hiding this comment.
Generally LGTM, added few nits.
src/main/java/org/spongepowered/api/data/type/ShieldDamageReduction.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/api/data/type/ShieldItemDamageFunction.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/api/data/type/ShieldDamageReduction.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/api/data/type/ShieldItemDamageFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/api/data/type/ShieldDamageReduction.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/api/data/type/ShieldItemDamageFunction.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/api/data/type/ShieldDamageReduction.java
Show resolved
Hide resolved
src/main/java/org/spongepowered/api/data/type/ShieldItemDamageFunction.java
Show resolved
Hide resolved
Co-authored-by: Joni Aromaa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | Sponge
Exposes
minecraft:blocks_attacksandminecraft:weapondata components.