Skip to content

Conversation

@anrayliu
Copy link
Collaborator

Proposed Changes/Description

Adding a new customizable label that when set to true, will cause the scheduler to skip that pvc.

Types of Changes

What types of changes does your code introduce to volume-cleaner? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (if none of the other choices apply)

Checklist

  • README.md or the Github Wiki documentation updated - if appropriate
  • Unit and/or integration tests added/modified
  • Lint and Unit tests pass locally with my changes

@anrayliu anrayliu self-assigned this Dec 25, 2025
@anrayliu
Copy link
Collaborator Author

I had to disable the go linter because the configuration was broken. No time to fix it since I'll be leaving soon, but someone else can take a look in the future.

@anrayliu
Copy link
Collaborator Author

anrayliu commented Dec 28, 2025

I also don't know if I'll have enough time to test this after it's deployed but I made a Jira ticket for volume cleaner housekeeping

Copy link
Contributor

@Jose-Matsuda Jose-Matsuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jose-Matsuda Jose-Matsuda merged commit 08f5d74 into main Jan 5, 2026
19 checks passed
@Jose-Matsuda Jose-Matsuda deleted the feat-ignore-label branch January 5, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants