Last step redirect after join a course #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ostrenkiy
suggested changes
Apr 26, 2018
Stepic/SectionsAPI.swift
Outdated
| class SectionsAPI: APIEndpoint { | ||
| override var name: String { return "sections" } | ||
|
|
||
| func retrieve(ids: [Int], existing: [Section], headers: [String: String] = AuthInfo.shared.initialHTTPHeaders) -> Promise<[Section]> { |
Contributor
Author
There was a problem hiding this comment.
Видимо незачем после рефакторинга? Сигнатуру взял из какого-то другого класса с API.
Stepic/LastStepRouter.swift
Outdated
|
|
||
| guard let unitId = course.lastStep?.unitId else { | ||
| openSyllabus() | ||
| // If last step does not exists then take first section and its first unit |
Contributor
There was a problem hiding this comment.
exists -> exist, опечатка
Stepic/LastStepRouter.swift
Outdated
| if let stepId = course.lastStep?.stepId { | ||
| fulfill(stepId) | ||
| } else { | ||
| let cachedLesson = Lesson.getLesson(unit.lessonId) |
Contributor
There was a problem hiding this comment.
Думаю, здесь лучше будет выглядеть cachedLesson = unit.lesson
Contributor
There was a problem hiding this comment.
Давай здесь все-таки сделаем что-то вроде let cachedLesson = unit.lesson ?? Lesson.getlesson(unit.lessonId)
| let cachedLesson = Lesson.getLesson(unit.lessonId) | ||
| ApiDataDownloader.lessons.retrieve(ids: [unit.lessonId], existing: cachedLesson == nil ? [] : [cachedLesson!]).then { lesson -> Void in | ||
| if let firstStepId = lesson.first?.stepsArray.first { | ||
| fulfill(firstStepId) |
Contributor
There was a problem hiding this comment.
А здесь хорошо было бы присвоить unit.lesson = lesson
Ostrenkiy
approved these changes
Apr 27, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1871
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Добавили переход к последнему пройденному шагу после записи на курс
Описание:
Вместо презентации секций используем везде после записи LastStepRouter. На странице "о курсе" теперь используется CourseSubscriber.