Add topic time to complete #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: - fetchProgress(id:, stepsService:) -> Guarantee<Double> - fetchProgresses(ids:, stepsService:) -> Guarantee<[Double]>
Update StepsServiceImpl to fetch steps if there is no cached one.
Now failable api request won't override cache data.
…ent' into feature/exam-topic-time-to-complete
kvld
approved these changes
Oct 2, 2018
| seal(self.computeProgress(steps: steps)) | ||
| }.catch { error in | ||
| print("Failed obtain progress for lesson with id: \(id), error: \(error)") | ||
| seal(0) |
Contributor
There was a problem hiding this comment.
т. е. при отсутствии полученного прогресса, мы примем 0 за прогресс? Не уверен, что это хорошо, когда есть nil.
Member
Author
There was a problem hiding this comment.
Сегодня буду фиксить баги, которые заметил и это поправлю в другом PR.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2046
Описание:
Добавили отображение времени на выполнение топика.