Skip to content

Removed social auth split test #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ostrenkiy merged 2 commits into from
Oct 16, 2018
Merged

Removed social auth split test #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cfc646
removed social auth split test
Ostrenkiy Oct 16, 2018
5390837
removed localization
Ostrenkiy Oct 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Stepic.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,6 @@
089877A2214047650065DFA2 /* SplitTestingService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0898779F214047650065DFA2 /* SplitTestingService.swift */; };
089877A6214047BC0065DFA2 /* AnalyticsUserPropertiesServiceProtocol.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089877A4214047BB0065DFA2 /* AnalyticsUserPropertiesServiceProtocol.swift */; };
089877AD214047EE0065DFA2 /* Numbers+Random.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089877A8214047EC0065DFA2 /* Numbers+Random.swift */; };
089877AF214047EE0065DFA2 /* SocialAuthStringSplitTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089877AA214047ED0065DFA2 /* SocialAuthStringSplitTest.swift */; };
089877B0214047EE0065DFA2 /* UserDefaults+StorageServiceProtocol.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089877AB214047ED0065DFA2 /* UserDefaults+StorageServiceProtocol.swift */; };
089877B221404CF10065DFA2 /* StringStorageServiceProtocol.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089877B121404CF00065DFA2 /* StringStorageServiceProtocol.swift */; };
089984291ECDE188005C0B27 /* LessonViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 089984281ECDE188005C0B27 /* LessonViewController.swift */; };
Expand Down Expand Up @@ -5275,7 +5274,6 @@
0898779F214047650065DFA2 /* SplitTestingService.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SplitTestingService.swift; sourceTree = "<group>"; };
089877A4214047BB0065DFA2 /* AnalyticsUserPropertiesServiceProtocol.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AnalyticsUserPropertiesServiceProtocol.swift; sourceTree = "<group>"; };
089877A8214047EC0065DFA2 /* Numbers+Random.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "Numbers+Random.swift"; sourceTree = "<group>"; };
089877AA214047ED0065DFA2 /* SocialAuthStringSplitTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SocialAuthStringSplitTest.swift; sourceTree = "<group>"; };
089877AB214047ED0065DFA2 /* UserDefaults+StorageServiceProtocol.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "UserDefaults+StorageServiceProtocol.swift"; sourceTree = "<group>"; };
089877B121404CF00065DFA2 /* StringStorageServiceProtocol.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StringStorageServiceProtocol.swift; sourceTree = "<group>"; };
089877B521407AB50065DFA2 /* Model_profile_staff_v24.xcdatamodel */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcdatamodel; path = Model_profile_staff_v24.xcdatamodel; sourceTree = "<group>"; };
Expand Down Expand Up @@ -7569,7 +7567,6 @@
089877B4214061EC0065DFA2 /* Active Tests */ = {
isa = PBXGroup;
children = (
089877AA214047ED0065DFA2 /* SocialAuthStringSplitTest.swift */,
);
name = "Active Tests";
sourceTree = "<group>";
Expand Down Expand Up @@ -14751,7 +14748,6 @@
083AE48120BD6DCC00102FE4 /* PersonalDeadlineLocalStorageManager.swift in Sources */,
2CA5E5A6200E1FC700CE77B0 /* AdaptiveRatingHelper.swift in Sources */,
0859AE991E4F1B8F00A0D206 /* FillBlanksChoiceTableViewCell.swift in Sources */,
089877AF214047EE0065DFA2 /* SocialAuthStringSplitTest.swift in Sources */,
0859AEA11E4F22B500A0D206 /* FillBlanksInputTableViewCell.swift in Sources */,
0888D1091F1E42A000A16863 /* CodeElementsSize.swift in Sources */,
080AA2321EA024290079272F /* CoursesAPIPaginatedMock.swift in Sources */,
Expand Down
4 changes: 1 addition & 3 deletions Stepic/SocialAuthPresenter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ class SocialAuthPresenter {
var pendingAuthProviderInfo: SocialProviderInfo?

var socialAuthHeaderString: String {
let test = splitTestingService.fetchSplitTest(SocialAuthStringSplitTest.self)
test.hitSplitTest()
return test.currentGroup.authString
return NSLocalizedString("SignInTitleSocial", comment: "")
}

init(authAPI: AuthAPI, stepicsAPI: StepicsAPI, notificationStatusesAPI: NotificationStatusesAPI, splitTestingService: SplitTestingServiceProtocol, view: SocialAuthView) {
Expand Down
42 changes: 0 additions & 42 deletions Stepic/SocialAuthStringSplitTest.swift
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions Stepic/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,9 +557,6 @@ PersonalDeadline = "Personal deadline";
DeadlineModeQuestion = "How much time would you like to spend studying on this course?";
PersonalDeadlineWidgetSuggestionText = "Constant learning is a key to success. We can smartly create personal learning schedule for you, so you'll never forget to study!";

/* Sign in AB */
SignInTitleSocialTest = "<b>Continue</b> with";

/* ExamEGERussian */
"ErrorMessage" = "Sorry, something went wrong: please try again later.";
"Ok" = "Ok";
Expand Down
3 changes: 0 additions & 3 deletions Stepic/ru.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,9 +558,6 @@ PersonalDeadline = "Персональный дедлайн";
DeadlineModeQuestion = "Сколько времени вы готовы тратить на изучение этого курса?";
PersonalDeadlineWidgetSuggestionText = "Постоянное обучение - путь к успеху. Мы можем создать для вас персональное умное расписание - так вы никогда не забудете получить порцию новых знаний!";

/* Sign in AB */
SignInTitleSocialTest = "<b>Продолжить</b> с помощью";

/* ExamEGERussian */
"ErrorMessage" = "Извините, что-то пошло не так: повторите попытку позже.";
"Ok" = "Ok";
Expand Down