Auth after onboarding ab #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-magda
requested changes
Oct 16, 2018
ivan-magda
reviewed
Oct 16, 2018
kvld
suggested changes
Oct 16, 2018
| self.analytics = analytics | ||
| } | ||
|
|
||
| typealias GroupType = Group |
| } | ||
| } | ||
|
|
||
| extension AuthAfterOnboardingSplitTest.Group { |
Contributor
There was a problem hiding this comment.
Кажется, что экстеншен не нужен. Енум же AuthAfterOnboardingSplitTest.Group, можно сразу всё описать
Contributor
Author
There was a problem hiding this comment.
Мне кстати кажется, что здесь с экстеншном удобнее. Давай просто договоримся, что там будем пилить все, что касается поведения групп (все, что не в этом экстеншне, можно +- копипастить из теста в тест, смысловой нагрузки там мало)
Contributor
There was a problem hiding this comment.
Сделаем так, как решит третий @vanyaland
Member
There was a problem hiding this comment.
В данном случае расширение ради одной переменной мне кажется излишне и можно сразу описать Group
LaunchDefaultsContainer.swift
Outdated
| if let startVersion = defaults.value(forKey: startVersionKey) as? String { | ||
| return startVersion | ||
| } else { | ||
| let version = Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") as! String |
Contributor
Author
|
Пофиксил |
ivan-magda
approved these changes
Oct 17, 2018
kvld
approved these changes
Oct 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2078
Описание:
Немного переписал то, как работает модуль для сплит-тестов. Теперь группа отсылаетя как user property при запуске приложения, а для каждого теста можно определять, должен ли пользователь в a/b-тесте участвовать.
Суть теста описана в задаче.