Fix permission alert presentation for notifications tab #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Present custom permission alert if delegate allowed, otherwise request authorization.
Member
Author
|
Раньше была странная логика: намного заранее выполнялась проверка на то, разрешил ли делегат показ кастомного алерта или нет. Сейчас выполнятется проверка текущего статуса авторизации и уже после этого выполняется представление алерта, если делегат разрешит. Кейсы, где запрашивается разрешение на получение нотификаций проверил и AB тест на регистрацию при запуске тоже. |
Ostrenkiy
approved these changes
Nov 30, 2018
kvld
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание:
Исправили запрос на получение разрешения доступа к пуш-уведомлениям с кастомным алертом. При переходе на вкладку нотификаций для новых пользователей (не выполнялся запрос на доступ к пушам от пользователя) каждый раз показывался алерт не учитывая предыдущие показы.
Скринкаст