Local push notifications #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Ostrenkiy можно смотреть и предлагать ещё интересные варианты пушей. |
Ostrenkiy
suggested changes
Aug 7, 2017
Contributor
Ostrenkiy
left a comment
Ostrenkiy
left a comment
There was a problem hiding this comment.
Нужно порефакторить StatsHelper так, чтобы его апишка была удобна.
И еще - давай избавимся от ненужных getMaxStreak и updateMaxStreak в пользу более модного и удобного var maxStreak : Int { get set } ?
| } | ||
| } | ||
|
|
||
| case tomorrow |
Contributor
There was a problem hiding this comment.
уф, хорошо бы это в начало enum-а перенести
|
|
||
| switch self { | ||
| case .tomorrow: | ||
| var curDay = StatsHelper.dayByDate(Date()) |
Contributor
There was a problem hiding this comment.
вычисление стрика лучше вынести в отдельный метод в StatsHelper-е
Contributor
There was a problem hiding this comment.
И curDay с вот этим StatsHelper.dayByDate(Date()) тоже можно как-то туда инкапсулировать. Например, загружать сегодняшнюю статистику обращаясь к одному проперти.
Ostrenkiy
approved these changes
Aug 7, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Локальные пуши в адаптивном приложении