Fix: System.Text.Json factories fail to generate if assembly name has hyphens#718
Merged
Fix: System.Text.Json factories fail to generate if assembly name has hyphens#718
Conversation
SteveDunn
commented
Dec 2, 2024
| // the following extension method is available if you specify `GenerateSwashbuckleMappingExtensionMethod` - as shown above | ||
|
|
||
| opt.MapVogenTypesInWebApplication(); | ||
| opt.MapVogenTypesInWebApplicationShared(); |
Owner
Author
There was a problem hiding this comment.
Previously, if the project named contained dots, then these would be stripped out, but now they're replaced with _. This was part of a bug fix for something else that derived the namespace from the project but failed where the project contained hyphens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #717