Bump actions/checkout from 4 to 5 #13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,7 +86,6 @@ module Setup = | |
|
|
||
| let Preparation = | ||
| (fun _ -> | ||
| Directory.ensure "./packages/fxcop/" | ||
|
|
||
| let target = | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <Solution> | ||
| <Folder Name="/Solution Items/"> | ||
| <File Path=".config/dotnet-tools.json" /> | ||
| <File Path=".github/workflows/main.yml" /> | ||
| <File Path="Build/build-rules.xml" /> | ||
| <File Path="Build/Directory.Build.props" /> | ||
| <File Path="Directory.Build.props" /> | ||
| <File Path="Directory.Build.targets" /> | ||
| <File Path="Directory.Packages.props" /> | ||
| <File Path="OutputBuildProps.props" /> | ||
| <File Path="OutputBuildTargets.props" /> | ||
| <File Path="README.md" /> | ||
| <File Path="ReleaseNotes - Previously.md" /> | ||
| <File Path="ReleaseNotes.md" /> | ||
| </Folder> | ||
| <Project Path="Build/Build.fsproj" /> | ||
| <Project Path="Build/Setup.fsproj" /> | ||
|
Comment on lines
+3
to
+17
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainVerify referenced paths exist and that actions/checkout is bumped to v5 in workflows This manifest references many files (including .github/workflows/main.yml). Let’s verify all referenced paths resolve and that workflows use actions/checkout@v5 and suitable runners. 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Checking that all referenced .slnx paths exist..."
python - << 'PY'
import xml.etree.ElementTree as ET, glob, os, sys
slnx_files = glob.glob('**/*.slnx', recursive=True)
missing = []
for slx in slnx_files:
tree = ET.parse(slx)
root = tree.getroot()
for elem in root.iter():
if elem.tag in ('File','Project'):
p = elem.get('Path')
if p and not os.path.exists(p):
missing.append((slx, p))
if elem.tag == 'BuildDependency':
p = elem.get('Project')
if p and not os.path.exists(p):
missing.append((slx, p))
if missing:
print('Missing paths referenced in .slnx:')
for slx, p in missing:
print(f' {slx}: {p}')
sys.exit(1)
print('All referenced paths in .slnx exist.')
PY
echo
echo "Inspecting actions/checkout usage in workflows..."
if fd -t f -g '.github/workflows/*.yml' >/dev/null 2>&1; then
echo "All checkout usages (context lines shown):"
rg -nP --no-heading -C2 '\buses:\s*actions/checkout@[^ \t]+' .github/workflows || true
echo
echo "Checking for non-v5 usages of actions/checkout..."
if rg -nP --no-heading '\buses:\s*actions/checkout@(?!v5(?:\b|\.))\S+' .github/workflows >/dev/null; then
echo "Found non-v5 usages of actions/checkout:"
rg -nP --no-heading -C1 '\buses:\s*actions/checkout@(?!v5(?:\b|\.))\S+' .github/workflows
exit 2
else
echo "All actions/checkout usages are v5 (or none found)."
fi
echo
echo "Runner targets:"
rg -nP --no-heading '^\s*runs-on\s*:' .github/workflows || true
else
echo "No workflow files found at .github/workflows/*.yml"
fiLength of output: 330 Missing file references in The solution manifest is referencing Build/*.fsx files that don’t exist in the repo:
These must either be added to version control or their Once the manifest is corrected, also verify that your GitHub workflows in
|
||
| </Solution> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| & dotnet tool update dotnet-reportgenerator-globaltool | ||
| & dotnet tool update altcode.gendarme-tool | ||
| & dotnet tool update dotnet-fsharplint | ||
| & dotnet tool update -g fantomas | ||
|
Comment on lines
+1
to
+4
There was a problem hiding this comment. 🛠️ Refactor suggestion Make tool updates deterministic and fail fast; bind to the local tool manifest explicitly As written, failures won’t stop the script, and updates depend on the current working directory implicitly containing the manifest. Tighten reliability and reproducibility. Apply this diff to add strict error handling, pin to the local manifest, and keep the global fantomas update: +Set-StrictMode -Version Latest
+$ErrorActionPreference = "Stop"
+
+Push-Location $PSScriptRoot
+try {
-& dotnet tool update dotnet-reportgenerator-globaltool
-& dotnet tool update altcode.gendarme-tool
-& dotnet tool update dotnet-fsharplint
-& dotnet tool update -g fantomas
+ & dotnet tool restore --tool-manifest .\.config\dotnet-tools.json
+ & dotnet tool update --tool-manifest .\.config\dotnet-tools.json dotnet-reportgenerator-globaltool
+ & dotnet tool update --tool-manifest .\.config\dotnet-tools.json altcode.gendarme-tool
+ & dotnet tool update --tool-manifest .\.config\dotnet-tools.json dotnet-fsharplint
+ & dotnet tool update -g fantomas
+}
+finally {
+ Pop-Location
+}🤖 Prompt for AI Agents |
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NUnit 4 vs NUnit 3 infrastructure mismatch likely to break test execution
You upgraded NUnit to 4.4.0 but still use NUnit3TestAdapter and nunit3-console (ConsoleRunner 3.x). NUnit 3 adapters/runners don’t execute NUnit 4 tests.
Two paths:
If you prefer to revert for now, change these lines:
If you want to proceed with NUnit 4, I can propose the compatible adapter/runner set.
📝 Committable suggestion
🤖 Prompt for AI Agents