Add support for the --profile cargo flag.#10
Merged
StratusFearMe21 merged 1 commit intoStratusFearMe21:masterfrom Jan 23, 2022
Merged
Add support for the --profile cargo flag.#10StratusFearMe21 merged 1 commit intoStratusFearMe21:masterfrom
--profile cargo flag.#10StratusFearMe21 merged 1 commit intoStratusFearMe21:masterfrom
Conversation
The primary change here is simply not passing the `--release` flag when `--profile` is present, since they conflict. But handling `--profile` correctly also requires looking in a different directory for the produced executables, which this commit also implements. This commit also incidentally fixes a bug where only a single command line argument was being passed on to the cargo build command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary change here is simply not passing the
--releaseflag when
--profileis present, since they conflict. Buthandling
--profilecorrectly also requires looking in adifferent directory for the produced executables, which this
commit also implements.
This commit also incidentally fixes a bug where only a single
command line argument was being passed on to the cargo build
command.
Addresses issue #8.