Skip to content

Add content description to few missing places#327

Merged
Stypox merged 2 commits intomasterfrom
accessibility
Jul 6, 2025
Merged

Add content description to few missing places#327
Stypox merged 2 commits intomasterfrom
accessibility

Conversation

@Stypox
Copy link
Owner

@Stypox Stypox commented Jul 4, 2025

Addresses points 1 and 2 of issue #325.

I am not sure how to handle point 3 yet, there are too many buttons around the app and most of them already explain what is supposed to happen when you tap on them, so adding onClick semantics feels redundant. For example, I think it's better if, when the microphone button is focused, the talkback said "Start listening button, double tap to activate" instead of "Start listening button, double tap to start listening". The latter feels redundant. https://github.com/zhou-zhoukang can you help me pinpoint in which places it would be helpful to add onClick semantics?

Debug APK: https://github.com/Stypox/testing-apks/releases/download/16/app-debug.apk

@Stypox Stypox linked an issue Jul 4, 2025 that may be closed by this pull request
@Stypox Stypox mentioned this pull request Jul 4, 2025
@zhou-zhoukang
Copy link

I have seen the new APK. Thank you for your effort, all the issues have been resolved, and it looks very good.

9DDCC20561C7F45E6E53EBC84FD8F14B

Regarding the onClick Label, it's true that it's not always necessary when the button already has descriptive text.

@Stypox
Copy link
Owner Author

Stypox commented Jul 6, 2025

Thanks for the feedback!

@Stypox Stypox merged commit 77bef04 into master Jul 6, 2025
@Stypox Stypox deleted the accessibility branch February 20, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some Accessibility issues

2 participants