Add content description to few missing places#327
Merged
Conversation
Owner
Author
|
Thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Addresses points 1 and 2 of issue #325.
I am not sure how to handle point 3 yet, there are too many buttons around the app and most of them already explain what is supposed to happen when you tap on them, so adding onClick semantics feels redundant. For example, I think it's better if, when the microphone button is focused, the talkback said "Start listening button, double tap to activate" instead of "Start listening button, double tap to start listening". The latter feels redundant. https://github.com/zhou-zhoukang can you help me pinpoint in which places it would be helpful to add
onClicksemantics?Debug APK: https://github.com/Stypox/testing-apks/releases/download/16/app-debug.apk