feat(otellogs): add hostNetwork and dnsPolicy configuration#3993
feat(otellogs): add hostNetwork and dnsPolicy configuration#3993azamorano wants to merge 2 commits intoSumoLogic:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@azamorano thank you for your contribution! Recommend that we also add an Integration test for this change to validate that the pods in the logs daemonset startup without issues. This should also test whether a pod would need associated clusterRole changes to run on this mode and that the logs are being received by sumologic. |
echlebek
changed the title
echlebek
left a comment
echlebek
left a comment
There was a problem hiding this comment.
It appears that this change has lead to one of the integration tests breaking
|
@echlebek sorry for the late response. I did not have much time to take a look to this. |
|
Hi @echlebek did you have a chance to take a look to my comment above? |
rnishtala-sumo
left a comment
rnishtala-sumo
left a comment
There was a problem hiding this comment.
Added a comment about the template tests. I'd also recommend creating an issue or updating the description for this PR, to help understand the motivation to enable hostNetwork.
| require.Equal(t, "50%", logsCollectorDaemonset.Spec.UpdateStrategy.RollingUpdate.MaxUnavailable) | ||
| } | ||
|
|
||
| func TestCollectorDaemonsetHostNetwork(t *testing.T) { |
There was a problem hiding this comment.
Could we plug into the existing template tests? I think we'll need to define the input and output files. See - https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/tests/helm/README.md
|
This PR is stale because it has been open for 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
3 participants
Allows for configurable
hostNetworkanddnsPolicy. Related with #3940Checklist