Skip to content

Comments

Particles for badguys and Tux#2831

Open
weluvgoatz wants to merge 8 commits intoSuperTux:masterfrom
weluvgoatz:badguy-particles
Open

Particles for badguys and Tux#2831
weluvgoatz wants to merge 8 commits intoSuperTux:masterfrom
weluvgoatz:badguy-particles

Conversation

@weluvgoatz
Copy link
Member

@weluvgoatz weluvgoatz commented Mar 17, 2024

Part of what turns a meh game into a great game is having visual feedback whenever you engage in a special event. One way in which this can be incorporated into SuperTux is by adding some particles upon killing or squishing enemies. I added exactly that in this PR, alongside some particles for when significant impacts are made (like when an enemy hits a wall at a fast speed.)

Please test this PR, it is my first contribution in almost a year and I made it rather quickly, and surely there will be some design decisions to be made, and I will definitely be willing to work with that. But I think this is a good start.

The graphics added in this PR are created by RustyBox.

UPDATE: I am also updating Tux's particles here.

@tobbi
Copy link
Member

tobbi commented Mar 17, 2024

Video would be nice.

@weluvgoatz
Copy link
Member Author

Here is a video:
https://www.youtube.com/watch?v=y0qKR7CU4Rg

- Star particles replaced with the generic particle sprite
- these particles now only occur when an enemy is knocked off screen
- melt particles adjusted
- side particles amount now configurable, so some side particles (like ___shot enemies) release more particles, and enemies such as haywire, iceblock etc. hitting wall only release a few.
- Leaf particles adjusted to spread out.
@tobbi
Copy link
Member

tobbi commented Mar 18, 2024

IDK if I like this. The way the particles spawn is too generic. Could we have different effects per badguy?

@mrkubax10
Copy link
Member

I like the idea but I would leave out collision particles because it may get laggy very quickly.

@Rusty-Box
Copy link
Member

Rusty-Box commented Mar 23, 2024

Some suggestions after testing:

  • I think particles should slowly begin fading out after a couple seconds. They stay too long, especially noticable with leaf particles.
  • The "dust-type" / neutral paritcle should also have lower gravity. I wanna update their sprite to actually look more dust like. Right now they look too much like a rock
  • Snowballs etc currently have two instances of particle effect play at once. You can at least hear the melt sound twice!

Side note, I'm gonna make some more particles sprites soon that you can use. I was planning for sprite used for: Granito, Flying Snowball, Stalactite and Mr. Tree/Stumpy. Just to let you know

@weluvgoatz weluvgoatz changed the title Particles for badguys Particles for badguys and Tux Mar 26, 2024
- Made dust particles gravity slower
- Added fade out to particles that are on screen for a long time, like leaf
- Brought back star particles for knocking enemy off screen only. Looks better than whatever was before.
@tobbi
Copy link
Member

tobbi commented Mar 29, 2024

I think particles should spawn from the center of the squished sprite and not from the center of the normal sprite.

@weluvgoatz weluvgoatz added this to the 0.7.0 milestone Apr 20, 2024
@Alasdairbugs Alasdairbugs self-requested a review February 9, 2025 21:41
@Alasdairbugs Alasdairbugs modified the milestones: 0.7.0, 0.7.1 Feb 9, 2025
@Alasdairbugs
Copy link
Contributor

Revisiting this, I think its a good idea to add particles but it'll be needed for every new enemy in the future. is this something we're willing to add onto the already large workload of making an enemy: drawing, animating, designing, and coding them in? I think it'll be better to worry about this closer to a 1.0 release when most, if not all, enemies are in the game.

@weluvgoatz
Copy link
Member Author

I was also thinking about this yesterday, I think I might limit the scope for now - just particles for Tux (buttjump), explosions, and crushers (all using the generic particles already here). Then we can focus on more robust particles for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants