Canvas::get_pixel: Use a virtual colorspace#2931
Draft
Conversation
Virtual colorspaces, consisting of colored shapes, can now be used for the `get_pixel` API, instead of relying on the GPU. **TODO:** [ ] Detect, or allow to specify lightsprites as circles with a radius and border radius, making the light check more visually correct. [ ] Make sure the shape of every lightsprite, needed to be detected by the `get_pixel` API, is being added into the `LIGHTSPRITES` colorspace. [ ] More extensive testing. Fixes #2661. Fixes #1939 (theoretically, should also be tested).
provigz
added
status:in-progress
|
Perhaps call it something other than a color space, given that the term already has a well-established definition? Something like a virtual canvas layer, maybe, since it's basically an additional simple CPU-side render target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual colorspaces, consisting of colored shapes, can now be used for the
get_pixelAPI, instead of relying on the GPU.TODO:
Spotlightlight sprite into two and draw them separately, to achieve a more exact light check by specifying a circle radius for each.get_pixelAPI, is being added into theLIGHTSPRITEScolorspace.Fixes #2661. Fixes #1939 (theoretically, should also be tested).