Open
Conversation
…ailable languages
Member
Author
|
Note: After consulting with other people from the team, it is clear that the slowdown on Android isn't primarily due to us parsing too many physfs paths but rather, that we appear to be loading the entire data ZIP file into memory when loading languages (or something similar). Nonetheless, this will be an improvement on other OSes, probably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, tinygettext queried the entire search path for .po files and added those to the list of languages. With all the installed add-ons adding their paths to the tinygettext search path, this obviously caused an immense slowdown.
I've added an overload to the
get_languages()method to tinygettext to only load .po files from the "locale" directory. We should only be looking there, anyway.I've opened a PR on our tinygettext fork here: SuperTux/tinygettext#7