Skip to content

Comments

Add a toggle for screen shake effects#3613

Open
v1993 wants to merge 2 commits intoSuperTux:masterfrom
v1993:disable-screenshake
Open

Add a toggle for screen shake effects#3613
v1993 wants to merge 2 commits intoSuperTux:masterfrom
v1993:disable-screenshake

Conversation

@v1993
Copy link

@v1993 v1993 commented Feb 4, 2026

Fixes #3609.

Marking as draft since I've realized it might be a good idea to make it tri-state instead:

  • Full (default): both one-time shakes (e.g. from bombs) and "earthquakes" (persistent shaking) enabled
  • Reduced: only one-time shakes enabled
  • Off: both one-time shakes and "earthquakes" disabled

Should I go for that? If so, should I bother with an enumeration (like video subsystem selection) or would a simple int (like for vsync) do?

@swagtoy
Copy link
Member

swagtoy commented Feb 4, 2026

Should I go for that?

Yes

should I bother with an enumeration

For tri-state, yes. It does no harm

@v1993 v1993 marked this pull request as ready for review February 4, 2026 07:34
@v1993 v1993 force-pushed the disable-screenshake branch from 7f54985 to 9065ab5 Compare February 4, 2026 07:36
@v1993
Copy link
Author

v1993 commented Feb 4, 2026

Changed to off/reduced/full selection as proposed, seems to work well in testing. Using an enum means that there are three formats to convert between (selection number <-> enum <-> string), which is a bit unwieldy, but ultimately works okay.

@v1993 v1993 requested a review from swagtoy February 4, 2026 07:39
@swagtoy
Copy link
Member

swagtoy commented Feb 4, 2026

I'll review tomorrow, ping if I forget. Thank you very much for your work!

@v1993
Copy link
Author

v1993 commented Feb 7, 2026

@swagtoy Ping! Also, a look at #3540 would be appreciated as well.

@swagtoy
Copy link
Member

swagtoy commented Feb 9, 2026

I'm really sorry. will get back to this soon

Copy link
Contributor

@MatusGuy MatusGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this interfere with string freeze?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow turning screen shake off

3 participants