Add a toggle for screen shake effects#3613
Open
v1993 wants to merge 2 commits intoSuperTux:masterfrom
Open
Conversation
Member
Yes
For tri-state, yes. It does no harm |
swagtoy
requested changes
Feb 4, 2026
7f54985 to
9065ab5
Compare
Author
|
Changed to off/reduced/full selection as proposed, seems to work well in testing. Using an enum means that there are three formats to convert between (selection number <-> enum <-> string), which is a bit unwieldy, but ultimately works okay. |
Member
|
I'll review tomorrow, ping if I forget. Thank you very much for your work! |
Author
Member
|
I'm really sorry. will get back to this soon |
MatusGuy
reviewed
Feb 20, 2026
Contributor
MatusGuy
left a comment
There was a problem hiding this comment.
Could this interfere with string freeze?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3609.
Marking as draft since I've realized it might be a good idea to make it tri-state instead:
Should I go for that? If so, should I bother with an enumeration (like video subsystem selection) or would a simple
int(like for vsync) do?