Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "Leave script" to scripttriggers. This script is triggered upon losing contact with the trigger. It doesn't activate in "button" mode. I made it so that the scripttrigger's trigger counter in non-button mode only increases after leaving the trigger, meaning that in "oneshot" mode, the regular script and the leave script will each trigger once but not again after re-entering the scripttrigger area.
I also added the m_ prefix for member variables in the ScriptTrigger class.
Why? This:
(it's from The Curse of Quiddlesworth, and this is a common theme across the add-on; this PR, if merged, would cut the amount of scripttriggers used in there by 60-70%)
DO NOT MERGE until after 0.7.0