Instructor: enroll students: allow same team name across sections

[damithc]

'team 1' in tutorial 1 should be considered different from 'team 1' in tutorial 2

[Haozhe321]

@damithc this would change the following method

teammates/src/main/java/teammates/logic/core/StudentsLogic.java

Lines 423 to 449 in 30a7659

	private String getTeamInvalidityInfo(List<StudentAttributes> mergedList) {
	StudentAttributes.sortByTeamName(mergedList);
	List<String> invalidTeamList = new ArrayList<>();
	for (int i = 1; i < mergedList.size(); i++) {
	StudentAttributes currentStudent = mergedList.get(i);
	StudentAttributes previousStudent = mergedList.get(i - 1);
	if (currentStudent.team.equals(previousStudent.team)
	&& !currentStudent.section.equals(previousStudent.section)
	&& !invalidTeamList.contains(currentStudent.team)) {
	invalidTeamList.add(currentStudent.team);
	}
	}
	StringBuilder errorMessage = new StringBuilder(100);
	for (String team : invalidTeamList) {
	errorMessage.append(String.format(Const.StatusMessages.TEAM_INVALID_SECTION_EDIT,
	SanitizationHelper.sanitizeForHtml(team)));
	}
	if (errorMessage.length() != 0) {
	errorMessage.append("Please use the enroll page to edit multiple students");
	}
	return errorMessage.toString();
	}

In that case, what would constitute an invalid team info?

[damithc]

In that case, what would constitute an invalid team info?

Nothing I guess. However, note that we need to tweak our UI (and the logic) in many place to distinguish multiple teams with the same name but in different sections. e.g., show sec1/team1 instead of showing team1 only.

[Haozhe321]

Should a new variable be added in TeamDetailsBundle class, i.e. the sectional this team belongs to?
One consideration of this is backwards compatibility with students created before this change takes place.

Since this is a big change, I want to be clear of the steps taken. Here are some of the areas that would be affected by the change. Let me know if there are other considerations. Right now I have

1. UI of team name for feedback result (every time a team name needs to be displayed, it has to be accompanied with the section name as well)
2. Feedback path to own team and other teams(a team name cannot uniquely determine the team of the student anymore, the section name would be needed)

How should I proceed to solve this issue systematically i.e. which part of the code base should be changed before the others?

@wkurniawan07 would love to have your input on this as well!

[wkurniawan07]

@Haozhe321 TeamDetailsBundle is not persisted to DB; modifying it should not have any backward-incompatibility issue.

I'm not familiar with this feature myself, but if anything, the result should be the last of all the worries (i.e. worry about the POST before the GET), so the first thing to loosen the criteria for team name uniqueness when adding new teams. Afterwards all code which retrieve team information by name only should be changed to retrieving by name and section name.