Skip to content

Conversation

@Zxun2
Copy link
Contributor

@Zxun2 Zxun2 commented Jul 14, 2023

Fixes #12517

Outline of Solution

Overwrite default attributes inherited from base class.

Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the hotfix ZX!

@domlimm domlimm requested a review from weiquu July 14, 2023 15:43
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weiquu weiquu merged commit 02bf5c2 into TEAMMATES:master Jul 14, 2023
@samuelfangjw
Copy link
Member

Thanks @Zxun2, @domlimm, @weiquu for the quick fix!

@samuelfangjw samuelfangjw added c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging labels Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.1 milestone Jul 14, 2023
@damithc
Copy link
Contributor

damithc commented Jul 14, 2023

Thanks @Zxun2, @domlimm, @weiquu for the quick fix!

Yup 💯

samuelfangjw pushed a commit that referenced this pull request Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c.Bug Bug/defect report s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instructors creating sessions: response visible time should be 'not now' by default

5 participants