[#12695] implement createSpyFromClass test-helper #12696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cedricongjh, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
cedricongjh
changed the title
ziqing26
approved these changes
Jan 23, 2024
Contributor
ziqing26
left a comment
ziqing26
left a comment
There was a problem hiding this comment.
The helper LGTM! Just one question: would it be good to change other tests that mock services in this PR as well? For example, src/web/services/course.service.spec.ts
wkurniawan07
added
s.ToMerge
cedricongjh
added a commit
to cedricongjh/teammates
that referenced
this pull request
Feb 20, 2024
…#12696) * implement createSpyFromClass test-helper * update all spys to use new test utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12695
Outline of Solution
Create
createSpyFromClasstest utility function to automatically create spy objects for us