adjust all log-levels besides WARN to TRACE#1050
Merged
codecholeric merged 3 commits intomainfrom Feb 2, 2023
Merged
Conversation
hankem
approved these changes
Jan 25, 2023
archunit/src/main/java/com/tngtech/archunit/core/domain/JavaType.java
Outdated
Show resolved
Hide resolved
codecholeric
force-pushed
the
reduce-all-log-output-to-trace
branch
from
17aeb84 to
06c9795
Compare
codecholeric
force-pushed
the
reduce-all-log-output-to-trace
branch
3 times, most recently
from
2dbeed6 to
f3eb9f7
Compare
Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
The comment on `JavaField.getType()` was a leftover from a previous time before generics support was fully implemented. Meanwhile, the described "possible" future has already become reality. I've noticed that the Javadoc on `JavaType` and `HasType` was a little sparse, so I tried to extend that instead. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
Over the years there have been continuous issues by people not configuring their logging system appropriately and then being spammed by masses of DEBUG logs. In particular, because ArchUnit hooks into SLF4J and as it seems e.g. Spring Boot sets the log-level to DEBUG if the configuration is missing. While I principally think people should just correctly configure their logging infrastructure I've also been worn down over time ;-) So, I will reduce all non-WARN levels to TRACE now and accept that it will not be possible anymore to distinguish extremely spammy output (like "found access from x to y") from more central output (like "dependency resolution configuration") by log-level. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
codecholeric
force-pushed
the
reduce-all-log-output-to-trace
branch
from
f3eb9f7 to
69227cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over the years there have been continuous issues by people not configuring their logging system appropriately and then being spammed by masses of DEBUG logs. In particular, because ArchUnit hooks into SLF4J and as it seems e.g. Spring Boot sets the log-level to DEBUG if the configuration is missing. While I principally think people should just correctly configure their logging infrastructure I've also been worn down over time ;-) So, I will reduce all non-WARN levels to TRACE now and accept that it will not be possible anymore to distinguish extremely spammy output (like "found access from x to y") from more central output (like "dependency resolution configuration") by log-level.
Resolves: #1038
Resolves: #1049