enable @AnalyzeClasses annotation to be used as meta annotation#1300
Conversation
253c79e to
f28257a
Compare
.../junit5/engine/src/main/java/com/tngtech/archunit/junit/internal/ArchUnitTestDescriptor.java
Outdated
Show resolved
Hide resolved
f28257a to
4e75e03
Compare
This method is not used directly from any code outside `ReflectionUtils`, thus it should be an implementation detail and `private`. The test coverage of the methods using this transitively seems good enough. Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
... to better motivate why it's there, since it's private. Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
4e75e03 to
861bf33
Compare
|
Thanks a lot for your support! 😃 The PR looked really nice to me 👍 I still just made some changes, but that has nothing to do with the quality. In particular:
In any case, I just went ahead and changed this, I really hope you don't mind! It's mainly because I have a hard time these days to make time to work on ArchUnit (as you might notice by the delay of this review 🙈), so having a lot of round-trips on the review would likely slow down the merge considerably. If there is something really wrong with the final state, we can still fix it in a follow-up. |
so far users are forced to repeat `@AnalyzeClasses` annotation an every test class. This cause additional maintenance overhead when common properties (e.g. package structure) changes. To support the DRY approach, `@AnalzyeClasses` annotation can now be used as meta annotation. Resolves: TNG#182 Signed-off-by: Mathze <270275+mathze@users.noreply.github.com>
861bf33 to
9e90a3b
Compare
|
Hi @codecholeric, don't worry, I'm glad that it made it into code :) and I could support. I know maintaining OSS isn't an easy job especially if done in sparetime. |
so far users are forced to repeat
@AnalyzeClassesannotation an every test class. This cause additional maintenance overhead when common properties (e.g. package structure) changes. To support the DRY approach,@AnalzyeClassesannotation can now be used as meta annotation.Resolves: #182