add general coding rules for assertion messages and deprecated APIs#970
Merged
codecholeric merged 2 commits intomainfrom Dec 27, 2022
Merged
add general coding rules for assertion messages and deprecated APIs#970codecholeric merged 2 commits intomainfrom
codecholeric merged 2 commits intomainfrom
Conversation
hankem
force-pushed
the
extend-general-coding-rules
branch
from
2e9c591 to
d0ee71a
Compare
hankem
force-pushed
the
extend-general-coding-rules
branch
from
d0ee71a to
3ea44df
Compare
hankem
changed the title
hankem
force-pushed
the
extend-general-coding-rules
branch
from
3ea44df to
97a5a73
Compare
hankem
force-pushed
the
extend-general-coding-rules
branch
from
97a5a73 to
cbef736
Compare
Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
codecholeric
force-pushed
the
extend-general-coding-rules
branch
2 times, most recently
from
6148800 to
e1d5a1b
Compare
Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
codecholeric
force-pushed
the
extend-general-coding-rules
branch
from
e1d5a1b to
3d48c64
Compare
codecholeric
approved these changes
Dec 27, 2022
Collaborator
codecholeric
left a comment
codecholeric
left a comment
There was a problem hiding this comment.
Looks good, thanks a lot!! 🙂 I'm gonna merge it even though the JDK 10 test fails, because as discussed I think this is some problem with the test environment. The same test runs fine on my local Ubuntu machine with the provisioned JDK 😒
codecholeric
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two more
GeneralCodingRules:ASSERTIONS_SHOULD_HAVE_DETAIL_MESSAGEresolves Can ArchUnit check that assertions include a message? #963DEPRECATED_API_SHOULD_NOT_BE_USEDchecks that no class accesses members (i.e. calls methods or constructors, or accesses fields) that are either@Deprecatedthemselves or declared in@Deprecatedclasses, or references@Deprecatedclass objects.