Add explicitly listed artifacts to sources#161
Open
dfuchsgruber wants to merge 2 commits intomasterfrom
Open
Conversation
Collaborator
|
Instead of listing files or directories wouldn't it make more sense to allow for arbitrary globs? That makes our code easier and allows for globs within the configuration like **/*.yaml ? |
Collaborator
|
from what I can tell, there's no change to the database scheme, right? So, we shouldn't expect any problems with existing collections? |
Contributor
Author
|
Good idea. Added support for glob patterns. |
Collaborator
|
I'd propose that there should be one pattern not multiple, i.e., only do globs and no-implicit globs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR enables explicitly listing files / folders in the experiment's
semlconfiguration that will be uploaded to MongoDB. This can be used for all sort of artifacts that are relevant to run experiments but are not explicitly detected by source code discovery which only considers.pyfiles.Additional information
_SEML_COMPLETE=1 typer seml.__main__ utils docs --name seml --output docs.mdor did not change the CLI.