Skip to content

Fix ordering of ts update overloads & fix a lot of type errors in tests #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KyleAMathews merged 10 commits into from
Jun 12, 2025
Merged

Fix ordering of ts update overloads & fix a lot of type errors in tests #166

KyleAMathews merged 10 commits into from
Jun 12, 2025

Conversation

@KyleAMathews
Copy link
Collaborator

@KyleAMathews KyleAMathews commented Jun 12, 2025 •
edited
Loading

Fix #147

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 6c89fd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@tanstack/db Patch
@tanstack/db-collections Patch
@tanstack/react-db Patch
@tanstack/vue-db Patch
@tanstack/db-example-react-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KyleAMathews KyleAMathews requested a review from samwillis June 12, 2025 14:33
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 12, 2025 •
edited
Loading

@tanstack/db-example-react-todo

npm i https://pkg.pr.new/@tanstack/db@166

npm i https://pkg.pr.new/@tanstack/db-collections@166

npm i https://pkg.pr.new/@tanstack/react-db@166

npm i https://pkg.pr.new/@tanstack/vue-db@166

commit: 6c89fd6

samwillis
samwillis approved these changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think there are a few places we will have conflicts with #155 in the tests where we fixed the same problems 😁

eslint.config.mjs
...prettierConfig.rules,
"@typescript-eslint/no-unused-vars": [
`error`,
{ argsIgnorePattern: `^_`, varsIgnorePattern: `^_` },
Copy link
Collaborator

@samwillis samwillis Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to se you add this rule 😂

Copy link
Collaborator Author

@KyleAMathews KyleAMathews Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha I'll do the merge this time then 👍

@KyleAMathews KyleAMathews merged commit 02adc81 into main Jun 12, 2025
4 checks passed
@KyleAMathews KyleAMathews deleted the fix-update-types branch June 12, 2025 21:17
@github-actions github-actions bot mentioned this pull request Jun 12, 2025
Merged
cursor bot pushed a commit that referenced this pull request Jul 16, 2025
@KyleAMathews
Fix ordering of ts update overloads & fix a lot of type errors in tes…
de34007 
…ts (#166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samwillis samwillis samwillis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update callback isn't typed

3 participants

@KyleAMathews @samwillis