Skip to content

Compiler fixes#1035

Merged
crutchcorn merged 9 commits intomainfrom
compiler-fixes
Nov 29, 2024
Merged

Compiler fixes#1035
crutchcorn merged 9 commits intomainfrom
compiler-fixes

Conversation

@crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Nov 25, 2024

This PR:

  • Removes form.useField API, as it does not follow the rules of React Hooks
  • Removes form.useStore API, as it does not follow the rules of React Hooks
  • Adds a React Compiler example
  • Fixes issues with data not re-rendering in React Compiler
  • Adds ESLint rules of React Compiler to the codebase

TODO

  • Updates test to avoid ESLint warnings about React Compiler

@nx-cloud
Copy link

nx-cloud bot commented Nov 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c77e482. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1035

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1035

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1035

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1035

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1035

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@1035

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1035

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@1035

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@1035

commit: c77e482

@codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.12%. Comparing base (98ef482) to head (c77e482).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
+ Coverage   86.10%   86.12%   +0.02%     
==========================================
  Files          28       28              
  Lines        1108     1110       +2     
  Branches      276      277       +1     
==========================================
+ Hits          954      956       +2     
  Misses        141      141              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 1a88b6f into main Nov 29, 2024
@crutchcorn crutchcorn deleted the compiler-fixes branch November 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant