fix(solid-form): Build ESM, CJS, and source#844
Merged
lachlancollins merged 1 commit intoTanStack:mainfrom Jul 10, 2024
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c25deb2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 91.55% 91.66% +0.11%
==========================================
Files 21 2 -19
Lines 900 36 -864
Branches 206 1 -205
==========================================
- Hits 824 33 -791
+ Misses 71 3 -68
+ Partials 5 0 -5 ☔ View full report in Codecov by Sentry. |
lachlancollins
approved these changes
Jul 10, 2024
Member
lachlancollins
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
This was referenced Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the changes discussed on Corbin's stream with Ryan.
esmandcjsbuilds are now generated again for use in no-build environmentssource, keeping with Solid ecosystem conventionssourceentrypoint is still.jsxto make sure that all JSX gets compiled properly