Skip to content

fix(solid-form): Build ESM, CJS, and source#844

Merged
lachlancollins merged 1 commit intoTanStack:mainfrom
Brendonovich:solid-form-exports
Jul 10, 2024
Merged

fix(solid-form): Build ESM, CJS, and source#844
lachlancollins merged 1 commit intoTanStack:mainfrom
Brendonovich:solid-form-exports

Conversation

@Brendonovich
Copy link
Contributor

@Brendonovich Brendonovich commented Jul 10, 2024

This implements the changes discussed on Corbin's stream with Ryan.

  • esm and cjs builds are now generated again for use in no-build environments
  • The JSX-preserving build is now generated in source, keeping with Solid ecosystem conventions
  • The source entrypoint is still .jsx to make sure that all JSX gets compiled properly

@nx-cloud
Copy link

nx-cloud bot commented Jul 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c25deb2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: c25deb2

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@844

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@844

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@844

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@844

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@844

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@844

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@844

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@844

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@844


templates

@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (5473bb8) to head (c25deb2).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
+ Coverage   91.55%   91.66%   +0.11%     
==========================================
  Files          21        2      -19     
  Lines         900       36     -864     
  Branches      206        1     -205     
==========================================
- Hits          824       33     -791     
+ Misses         71        3      -68     
+ Partials        5        0       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins changed the title chore: build solid-form for source, esm & cjs fix(solid-form): Build ESM, CJS, and source Jul 10, 2024
Copy link
Member

@lachlancollins lachlancollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants