fix(query-core) export Mutation class instead of exporting it as a type#7793
Merged
TkDodo merged 3 commits intoTanStack:mainfrom Jul 26, 2024
Merged
fix(query-core) export Mutation class instead of exporting it as a type#7793TkDodo merged 3 commits intoTanStack:mainfrom
TkDodo merged 3 commits intoTanStack:mainfrom
Conversation
previously, attempting to create a Mutation in a vanilla JS project required the use of the Mutation class constructor but due to it being exported as a type, we run into a runtime error stating that the Mutation type is not a class resulting in us not being able to proceed despite the compilation process in TypeScript not throwing an issue. This change exposes the class instead of the type in order to accomodate this requirement in vanilla JS projects fixes `Mutation` class isn't exposed from @tanstack/query-core TanStack#7785
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 71ecb30. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7793 +/- ##
===========================================
+ Coverage 44.58% 63.26% +18.68%
===========================================
Files 185 125 -60
Lines 7078 4533 -2545
Branches 1566 1266 -300
===========================================
- Hits 3156 2868 -288
+ Misses 3559 1437 -2122
+ Partials 363 228 -135 |
TkDodo
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, attempting to create a Mutation in a vanilla JS project required the use of the Mutation class constructor but due to it being exported as a type, we run into a runtime error stating that the Mutation type is not a class resulting in us not being able to proceed despite the compilation process in TypeScript not throwing an issue. This change exposes the class instead of the type in order to accomodate this requirement in vanilla JS projects
fixes
Mutationclass isn't exposed from @tanstack/query-core #7785