refactor(queryClient): accept generics on setQueryDefaults and setMutationDefaults#7903
Merged
DamianOsipiuk merged 3 commits intoTanStack:mainfrom Sep 3, 2024
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 139ecc5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
More templates
@tanstack/angular-query-experimental
@tanstack/angular-query-devtools-experimental
@tanstack/eslint-plugin-query
@tanstack/query-async-storage-persister
@tanstack/query-broadcast-client-experimental
@tanstack/query-core
@tanstack/query-devtools
@tanstack/query-persist-client-core
@tanstack/query-sync-storage-persister
@tanstack/react-query
@tanstack/react-query-devtools
@tanstack/react-query-next-experimental
@tanstack/react-query-persist-client
@tanstack/solid-query
@tanstack/solid-query-devtools
@tanstack/svelte-query
@tanstack/solid-query-persist-client
@tanstack/svelte-query-devtools
@tanstack/svelte-query-persist-client
@tanstack/vue-query
@tanstack/vue-query-devtools
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7903 +/- ##
===========================================
+ Coverage 45.16% 61.87% +16.70%
===========================================
Files 188 134 -54
Lines 7158 4666 -2492
Branches 1606 1287 -319
===========================================
- Hits 3233 2887 -346
+ Misses 3562 1537 -2025
+ Partials 363 242 -121 |
3 tasks
This was referenced Sep 25, 2024
Merged
This was referenced Sep 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer
I needed the same features and noticed that PR #5983 was closed without explanation. I assumed it might have been automatically closed due to the deletion of the
rcbranch (the base branch of that PR). I’ve picked up the work to resolve the remaining error and update the code with recent changes.I am not trying to take credit for @DarioSiroki's work and feel free to close this PR if #5983 is still valid. I apologize if I misunderstood the situation and the PR was closed for other reasons.
Description
This PR updates @DarioSiroki’s changes from PR #5983 by merging the latest updates from the main branch. It incorporates all recent modifications and resolves the remaining build error related to the vue-query library.