Skip to content

fix(query-core): jsdoc of notifyManager#8031

Merged
TkDodo merged 5 commits intoTanStack:mainfrom
manudeli:query-core/fix/jsdoc-notifyManager
Sep 9, 2024
Merged

fix(query-core): jsdoc of notifyManager#8031
TkDodo merged 5 commits intoTanStack:mainfrom
manudeli:query-core/fix/jsdoc-notifyManager

Conversation

@manudeli
Copy link
Collaborator

@manudeli manudeli commented Sep 8, 2024

Reflect #7935 (comment)

@manudeli manudeli marked this pull request as ready for review September 8, 2024 17:23
@nx-cloud
Copy link

nx-cloud bot commented Sep 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 45aaba2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 8, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8031

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8031

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8031

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8031

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8031

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8031

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8031

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8031

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8031

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8031

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8031

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8031

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8031

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8031

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8031

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8031

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8031

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8031

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8031

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8031

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8031

commit: 45aaba2

@manudeli manudeli marked this pull request as draft September 8, 2024 17:29
@codecov
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.82%. Comparing base (0f86b4d) to head (45aaba2).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8031       +/-   ##
===========================================
+ Coverage   44.51%   61.82%   +17.30%     
===========================================
  Files         195      135       -60     
  Lines        7279     4678     -2601     
  Branches     1629     1305      -324     
===========================================
- Hits         3240     2892      -348     
+ Misses       3662     1544     -2118     
+ Partials      377      242      -135     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 92.79% <89.47%> (-0.08%) ⬇️
@tanstack/query-devtools 4.86% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.50% <100.00%> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.51% <72.72%> (-0.44%) ⬇️
@tanstack/vue-query-devtools ∅ <ø> (∅)

@manudeli manudeli marked this pull request as ready for review September 8, 2024 19:38
@TkDodo TkDodo merged commit 2c1be7b into TanStack:main Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants