Add maxValue to label evaluation methods#10
Open
LuizCristino wants to merge 2 commits intoTappNetwork:mainfrom
Open
Add maxValue to label evaluation methods#10LuizCristino wants to merge 2 commits intoTappNetwork:mainfrom
LuizCristino wants to merge 2 commits intoTappNetwork:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This pull request updates the label evaluation logic in the
ProgressBarColumncomponent to provide more context when generating danger, warning, and success labels. Specifically, the maximum value of the progress bar is now passed to the label evaluation functions, allowing for more dynamic and context-aware label rendering.Label evaluation improvements:
getDangerLabel,getWarningLabel, andgetSuccessLabelmethods inProgressBarColumn.phpnow include themaxValue(retrieved viagetMaxValue()) in the array passed to the label evaluation callback. This enables label logic to consider both the current value and the maximum value when determining the appropriate label. [1] [2] [3]