[YouTube] Fix extraction of Shorts in channels and remove visitor data usage#1221
Merged
AudricV merged 3 commits intoTeamNewPipe:devfrom Sep 29, 2024
Merged
Conversation
This new UI data type is replacing the reelItemRenderer one.
It isn't required anymore and not used by extractor anymore since commit 5a6da5f, as the wrong page ID is used as a visitor data (the VerifiedStatus value as a string).
AudricV
added
bug
AudricV
changed the title
Stypox
approved these changes
Sep 13, 2024
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Code looks good to me, although I didn't test. Thank you!
This comment was marked as off-topic.
This comment was marked as off-topic.
6 tasks
2 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the extraction of Shorts in their channel tab due to a new UI element being rolled-out replacing the
reelItemRenderer,shortsLockupViewModel. It doesn't provide more information than areelItemRenderer.It also removes the usage of a visitor data in continuations of Shorts channel tabs, which used to be mandatory to get valid continuations with more Shorts. It isn't the case anymore, and the visitor data wasn't used since 5a6da5f, due to a lack of an index update with the channel IDs changes in this commit (the channel verified status was used instead).
The method
prepareDesktopJsonBuilderofYoutubeParsingHelperwith the visitor data argument isn't now used directly, but has been kept for now as it is (it will be very likely used with the PoToken changes for streaming URLs).Due to these visitor data changes, the mocks of
YoutubeChannelTabExtractorTest.Shortstest class had to be updated.Fixes TeamNewPipe/NewPipe#11554.