[SoundCloud] Miscellaneous refactors#1323
Merged
Stypox merged 13 commits intoTeamNewPipe:devfrom Oct 2, 2025
Merged
Conversation
This was referenced Jul 8, 2025
TobiGr
added
SoundCloud
3 tasks
ShareASmile
changed the title
Stypox
approved these changes
Oct 2, 2025
| public long getTimeStamp() throws ParsingException { | ||
| return getTimestampSeconds("(#t=\\d{0,3}h?\\d{0,3}m?\\d{1,3}s?)"); | ||
| final var timestamp = getTimestampSeconds("(#t=\\d{0,3}h?\\d{0,3}m?\\d{1,3}s?)"); | ||
| return timestamp == -2 ? 0 : timestamp; |
Member
There was a problem hiding this comment.
For a future PR, you could make getTimestampSeconds() return an Optional<>. Also, all regex-related functions should ideally only take Patterns, so we can avoid rebuilding regexes every time.
…eamLinkHandlerFactory Use non-capturing groups in regex Refactor Parser.java Add more utility methods (will be used in later commits)
…arameters. Refactor documentation also
Stypox
force-pushed
the
minor-code-cleanup
branch
from
d600f8d to
25113b2
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor refactorings