[YouTube] Correctly set uploaderUrl for lockup content type items#1344
[YouTube] Correctly set uploaderUrl for lockup content type items#1344litetex merged 1 commit intoTeamNewPipe:devfrom
uploaderUrl for lockup content type items#1344Conversation
ShareASmile
added
bug
|
Ok I will consolidate this with #1346 |
Fixes an issue, where the uploader URL for related items would be incorrect, due to the `YoutubeChannelLinkHandlerFactory.getUrl` expecting the id with a `channel/` prefix. However, the `browseId` used to extract the channel id is missing this prefix. Ref: TeamNewPipe#1320 Fix getUploaderUrl not resolving correct url
litetex
force-pushed
the
fix/invalid-related-id
branch
from
4b4c99e to
352fae6
Compare
| } | ||
|
|
||
| private String resolveUploaderUrlFromRelativeUrl(final String url) throws ParsingException { | ||
| return YoutubeChannelLinkHandlerFactory.getInstance().getUrl("c" + url); |
There was a problem hiding this comment.
Adding c results in https://www.youtube.com/c/@handle which is invalid! Also url should be renamed to something else, as it is not an entire URL.
| return YoutubeChannelLinkHandlerFactory.getInstance().getUrl("c" + url); | |
| return YoutubeChannelLinkHandlerFactory.getInstance().getUrl(url); |
There was a problem hiding this comment.
https://www.youtube.com/c/@handlewhich is invalid!
Well then YouTubeChannelExtractor is broken because it can't resolve https://www.youtube.com/@handle but successfully resolves https://www.youtube.com/c/@handle.
Update: Looks like there was something wrong on my end because https://www.youtube.com/@handle now also works...
Update v2: Ok now I'm really confused it sometimes works in the app and sometimes not. I'm not quite sure what's going on...
I will provide a fix for that in a new PR.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
4 participants
Fixes an issue, where the uploader URL for related items would be incorrect, due to the
YoutubeChannelLinkHandlerFactory.getUrlexpecting the id with achannel/prefix. However, thebrowseIdused to extract the channel id is missing this prefix.Ref: #1320
Fixes #1345