Skip to content

Bump protobufVersion from 4.32.1 to 4.33.0#1391

Merged
Stypox merged 2 commits intodevfrom
dependabot/gradle/protobufVersion-4.33.0
Oct 28, 2025
Merged

Bump protobufVersion from 4.32.1 to 4.33.0#1391
Stypox merged 2 commits intodevfrom
dependabot/gradle/protobufVersion-4.33.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2025

Bumps protobufVersion from 4.32.1 to 4.33.0.
Updates com.google.protobuf:protobuf-javalite from 4.32.1 to 4.33.0

Updates com.google.protobuf:protoc from 4.32.1 to 4.33.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 16, 2025
@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Oct 27, 2025

From the changelog:

 # Restored compatibility of runtime with gencode created with protoc <3.21

With this release, compatibility of the runtime with older gencode down to 3.0.0 is restored, compared to the previous support minimum of gencode created with 3.22+. Note that it is still strongly recommended to regenerate your gencode with a newer protoc and to avoid using gencode which was created with an old protoc.

Generated code from this range is covered by GHSA-h4h5-3hr4-j3g2 and is potentially vulnerable to a Denial of Service risk

[...]
Environment variables may be set to either throw an exception instead (-Dcom.google.protobuf.error_on_unsafe_pre22_gencode) or to entirely silence the logged messages (-Dcom.google.protobuf.use_unsafe_pre22_gencode)

As far as I understand, this is not a problem for us. Should we still set the -Dcom.google.protobuf.error_on_unsafe_pre22_gencode argument for CI builds?

@Stypox
Copy link
Copy Markdown
Member

Stypox commented Oct 27, 2025

I guess adding it won't hurt

dependabot bot and others added 2 commits October 27, 2025 16:52
@dependabot @TobiGr
Bump protobufVersion from 4.32.1 to 4.33.0
4926499 
Bumps `protobufVersion` from 4.32.1 to 4.33.0.

Updates `com.google.protobuf:protobuf-javalite` from 4.32.1 to 4.33.0

Updates `com.google.protobuf:protoc` from 4.32.1 to 4.33.0
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-javalite
  dependency-version: 4.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.protobuf:protoc
  dependency-version: 4.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@TobiGr
[CI] Set environment var to throw exception when compiling unsafe gen…
90a01ce 
…code

This sets an environment variable to let the build fail when compiling with potentially unsafe protobuf code. Generated code prior to protobuf version 3.22 might throw an error now.

This is necesarry because the unsafe code was blocked by newer protobuf versions, but is now allowed back to compile with protobuf version 4.33.0.

Ref: https://github.com/protocolbuffers/protobuf/releases/tag/v33.0
@TobiGr TobiGr force-pushed the dependabot/gradle/protobufVersion-4.33.0 branch from 4a62621 to 90a01ce Compare October 27, 2025 16:00
@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Oct 27, 2025

Done

Stypox
Stypox approved these changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Stypox Stypox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build still passes so I guess you can merge, thanks!

@Stypox Stypox merged commit 4368f2b into dev Oct 28, 2025
4 checks passed
@Stypox Stypox deleted the dependabot/gradle/protobufVersion-4.33.0 branch October 28, 2025 14:30
@TobiGr TobiGr mentioned this pull request Dec 21, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stypox Stypox Stypox approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TobiGr @Stypox