Skip to content

[YouTube] Extract uploader URL for videos with multiple uploaders#1397

Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom
FineFindus:fix/multiple-uploaders-url
Nov 3, 2025
Merged

[YouTube] Extract uploader URL for videos with multiple uploaders#1397
TobiGr merged 3 commits intoTeamNewPipe:devfrom
FineFindus:fix/multiple-uploaders-url

Conversation

@FineFindus
Copy link
Copy Markdown
Contributor

@FineFindus FineFindus commented Oct 31, 2025

Fixes an issue, where for videos with multiple uploaders/collaborators, the uploader URL could not be extracted, leading to the entire video failing to be extracted. This is fixed by extracting the URL of the first collaborator, which seems to be the main channel where the video is actually displayed.

However, this PR does not implement support for extracting all the uploaders.

Closes: #1333
Fixes: TeamNewPipe/NewPipe#12899

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Fixes an issue, where for videos with multiple uploaders/collaborators, the
uploader URL could not be extracted, leading to the entire video failing to be
extracted. This is fixed by extracting the URL of the first collaborator, which
appears to be the main channel where the video is actually displayed.

Closes: TeamNewPipe#1333
@TobiGr TobiGr added the YouTube Service, https://www.youtube.com/ label Oct 31, 2025
@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Oct 31, 2025

Thank you. However, this does not fully fix the issue. The uploaderAvatars also seem to be handled different here. The ownerRenderer does not have the thumbnail object anymore but an avatarStack instead. Would you like to take a look at this or should this be investigated by someone else?

@FineFindus
Copy link
Copy Markdown
Contributor Author

FineFindus commented Oct 31, 2025

I was already working on that :)

But I saw it as more important to update the StreamInfoItem extraction first, as that affects the feed extraction, and thus would break subscriptions.

Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Just one thought

Implements support for loading the channel details, of the channel that
actually owns the video, for videos with multiple uploaders.
@FineFindus FineFindus force-pushed the fix/multiple-uploaders-url branch from 5f08d76 to d051342 Compare November 1, 2025 08:16
@FineFindus FineFindus requested a review from TobiGr November 1, 2025 08:16
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TobiGr TobiGr merged commit 59b620c into TeamNewPipe:dev Nov 3, 2025
4 checks passed
@FineFindus FineFindus deleted the fix/multiple-uploaders-url branch November 3, 2025 15:52
FineFindus added a commit to FineFindus/NewPipeExtractor that referenced this pull request Nov 4, 2025
Implements support for extracting the collaborators of a video. This allows
client apps to display them, if they wish so. The first collaborator is
equivalent to the creator/uploader of the video.

Ref: TeamNewPipe#1397
FineFindus added a commit to FineFindus/NewPipeExtractor that referenced this pull request Nov 9, 2025
Implements support for extracting the collaborators of a video. This allows
client apps to display them, if they wish so. The first collaborator is
equivalent to the creator/uploader of the video.

Ref: TeamNewPipe#1397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

YouTube Service, https://www.youtube.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashing after searching something [YouTube] Check if videos with multiple uploaders are handled correctly

2 participants